Added dotnet-corvus-jsonschema #1184
Conversation
| COPY *.csproj . | ||
|
|
||
| COPY . . | ||
| RUN dotnet publish -c Release -o /app |
There was a problem hiding this comment.
It doesn't matter a ton, but you get better Docker layer caching if you do the dotnet restore separately as we do in the other .NET implementation I think.
There was a problem hiding this comment.
Interestingly, this doesn't work with a local build for me, so I reverted to a single restore, build, and publish. But I'll have another look now it is functioning.
There was a problem hiding this comment.
OK - I'm a bit stumped as to why this doesn't build!
There was a problem hiding this comment.
Oh, hang on - it's building on ARM64 for some reason...
There was a problem hiding this comment.
Yes. It doesn't all blow up on AMD64, but explodes on ARM64.
There was a problem hiding this comment.
I'm not expecting errors.
I'll set it up to preload the metaschema. I don't preload it automatically because you only need it if you need it!
There was a problem hiding this comment.
(Actually that's not strictly true - I'm expecting errors for the datetime leap year tests.)
There was a problem hiding this comment.
I've taken your changes and added the metaschema as pre-requisites for the test suite.
Let's see what that does...
There was a problem hiding this comment.
Sorry you caught me at the exact moment in the middle of some other release-related changes, but think you've got them now.
There was a problem hiding this comment.
You pulled in the harness changes but not the .NET workflow special casing. Here, let me simply merge the branch I pointed you at, and then the additional changes can go on top.
implementations/dotnet-corvus-jsonschema/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
|
OK I've merged all your initial commits along with the changes I mentioned to special case .NET onto main, so the only remaining changes (meaning left to be outstanding) should be the ones for the metaschema changes -- it might be easier to do that in a new PR (but I don't care either way personally so will leave this one open for you to close or not). Thanks again for adding your implementation! |
|
Thanks again! |
📚 Documentation preview 📚: https://bowtie-json-schema--1184.org.readthedocs.build/en/1184/