Fix linting errors #296
Merged
Fix linting errors #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In py3.8, which is now our min version
Mostly unused variables or imports
ZedThree
commented
Jul 27, 2023
|
|
||
| import xarray as xr | ||
| import xarray.testing as xrt | ||
| from xarray.core.utils import dict_equiv | ||
|
|
||
| from xbout.tests.test_load import bout_xyt_example_files, create_bout_ds |
There was a problem hiding this comment.
Ah, looks like this import was flagged as unused because it only appears as a fixture. Moving it to conftest.py is probably the best way to fix this
dschwoerer
approved these changes
Oct 4, 2023
| @@ -1,10 +1,8 @@ | |||
| import numpy as np | |||
| import random | |||
|
|
|||
| import pytest | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a workflow using
ruff(flake8 but fast)