-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linting errors #296
Fix linting errors #296
Conversation
In py3.8, which is now our min version
Mostly unused variables or imports
|
||
import xarray as xr | ||
import xarray.testing as xrt | ||
from xarray.core.utils import dict_equiv | ||
|
||
from xbout.tests.test_load import bout_xyt_example_files, create_bout_ds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, looks like this import was flagged as unused because it only appears as a fixture. Moving it to conftest.py
is probably the best way to fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup 👍
@@ -1,10 +1,8 @@ | |||
import numpy as np | |||
import random | |||
|
|||
import pytest | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a workflow using
ruff
(flake8 but fast)