-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernise packaging and CI #294
Conversation
Minimum supported version for python 3.8
- install dependencies from package - install package in separate step
- Delete tests from publish workflow, these should already have run! - Use credential-less "trusted publisher" workflow, see: https://docs.pypi.org/trusted-publishers/
Guessing the first line is due to xarray? Is it still a useful test overall? |
ERROR: Could not find a version that satisfies the requirement animatplot-ng==0.4.2 (from versions: 0.4.3) I am happy to remove those tests. |
Also explicitly use py 3.11 in tests Co-authored-by: David Bold <dschwoerer@users.noreply.github.com>
I think maybe an issue with the version of
|
I think it's useful in principle, but I'd be happy to bump the versions up a bit. I think it's mostly been useful for when xarray introduces some new functionality/syntax - if you change something that uses a new feature it might break xBOUT for users with an older xarray. Even then it's fine to force them to upgrade, but you need to know to bump the minimum required version required for xarray, etc. |
This version of netcdf4 doesn't have a binary wheel for py3.8, so gets built from source and needs numpy at build-time. Later versions do specify numpy as a built requirement.
Ok, having looked into this a bit more, the min-version test is nice in principle, but very fragile -- figuring out a consistent set of minimal versions that will work is very tricky. I'm struggling to install a set of minimal dependencies even locally. It might be best to drop this test completely. xarray is already pinned to |
I think everything except The 'min versions' test has saved me a few times from using something that was only available in the very latest xarray, so it would be nice to keep in some form if possible. |
Sure, happy to do that. Just to be clear, the other tests will only install xarray 2022.9.0, so they will also catch features only in more recent versions too. |
Fixes #253
pyproject.toml
, removesetup.cfg
,setup.py