Fixes for attributes of coordinates #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not read or alter ds after updated_ds is created, so delete the reference to ds to avoid errors.
|
Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-10 23:14:44 UTC |
An xarray bug (pydata/xarray#2180 (comment), pydata/xarray#4393, pydata/xarray#4415) can deletes attributes of coordinates when a new DataArray is assigned to a Dataset. This commit adds workarounds for that bug in several places. Also adds checks for if 'ycoord' and 'zcoord' already exist in apply_geometry() before creating them. Helps with re-applying apply_geometry() to existing or re-loaded Datasets.
johnomotani
force-pushed
the
fix-coord-attrs
branch
from
51fe097 to
451eda4
Compare
Workaround for possible bug with xarray, pydata/xarray#4417, needed for ensuring consistency so we can test for 'identical'.
Using assign_coords() can change existing coordinates on other variables, use a workaround instead to ensure more consistency.
Ensures input is not modified.
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 77.62% 77.69% +0.06%
==========================================
Files 14 14
Lines 2150 2156 +6
Branches 486 487 +1
==========================================
+ Hits 1669 1675 +6
Misses 308 308
Partials 173 173
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in xarray (pydata/xarray#2180 (comment), pydata/xarray#4393, pydata/xarray#4415) can result in attributes being deleted from coordinates when a new DataArray is added to a Dataset. This PR adds workarounds for that bug, and also some other fixes to make sure re-loaded Datasets get coordinates identical to the saved Dataset (including attrs).
Also added a work-around for a second weird possible bug in xarray pydata/xarray#4417.