Catch errors in HypnotoadGui.run() #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously was called in TokamakEquilibrium.makeRegions() which had the same effect as makeRegions is called from __init__, but it's clearer to call directly from __init__.
Adds xpoint_offset option to control how far points that should be at the X-point are shifted to avoid the null.
Some settings are needed in TokamakEquilibrium.__init(), so need to create a new object if they are changed before run().
Allow settings to be adjusted to retry, instead of hypnotoad-gui closing on any error.
johnomotani
force-pushed
the
allow-rerun
branch
from
da4d0ba
to
217955b
Compare
ZedThree
reviewed
Apr 27, 2020
|
Future wishlist: raise |
ZedThree
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows settings to be changed before trying
Runagain if there is an error.Also a couple of very small tidy up changes:
print options from
TokamakEquilibrium.__init__()instead ofTokamakEquilibrium.makeRegions()add setting to choose the displacement of grid points that should be at the X-point
Updated
doc/whats-new.mdwith a summary of the changes