Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/BE-43: Backend Unittests [2] #404

Merged
merged 9 commits into from
Dec 26, 2022
Merged

Feature/BE-43: Backend Unittests [2] #404

merged 9 commits into from
Dec 26, 2022

Conversation

BElifb
Copy link
Contributor

@BElifb BElifb commented Dec 26, 2022

  • Added tests for Bidding System and Recommendation System APIs.
  • 7 total for Bidding System.
  • 6 total for Recommendation System.
  • Tests check for multiple things, added comments about what each test checks for.
  • To run all the tests python manage.py test .
  • To run a single test python manage.py test -k <name_of_the_function>
  • To remove results rm test-output/*

@BElifb BElifb added Effort: Medium Priority: Low Issue can be handled in the long term Status: Review Needed A review is needed for this issue Coding The issue is related with coding Team: Backend issues related to backend labels Dec 26, 2022
@BElifb BElifb requested a review from KarahanS December 26, 2022 20:20
@BElifb BElifb self-assigned this Dec 26, 2022
@BElifb BElifb linked an issue Dec 26, 2022 that may be closed by this pull request
2 tasks
@KarahanS KarahanS changed the title Feature/BE-43: BE Tests+ Feature/BE-43: Backend Unittests [2] Dec 26, 2022
@KarahanS
Copy link
Contributor

KarahanS commented Dec 26, 2022

  • Changed the name of the PR to be consistent with the first unittest PR we had.
  • Due to the most recent bugfix and hotfix PRs, some of the previously written unit tests were not working properly. Updated those unit tests to reflect the most recent changes on our implementation.
  • Also there was a print statement left in one of the Recommendation related unittests. Removed that as well. Now, it's ready to go.

@BElifb BElifb merged commit 632d462 into master Dec 26, 2022
@KarahanS KarahanS deleted the feature/BE-43 branch December 26, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coding The issue is related with coding Effort: Medium Priority: Low Issue can be handled in the long term Status: Review Needed A review is needed for this issue Team: Backend issues related to backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BE-43: BE Tests+
2 participants