Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/BE-38: new_bids reset #397

Merged
merged 1 commit into from
Dec 26, 2022
Merged

hotfix/BE-38: new_bids reset #397

merged 1 commit into from
Dec 26, 2022

Conversation

BElifb
Copy link
Contributor

@BElifb BElifb commented Dec 26, 2022

  • The way that frontend was structured, didn't allow to pull new_bids info in a single call. So we changed the reset to every 2 calls.

@BElifb BElifb requested a review from sinemKocoglu December 26, 2022 17:04
@BElifb BElifb self-assigned this Dec 26, 2022
@BElifb BElifb added Effort: Low This issue can be easily handled Priority: Medium This issue should be handled, if there isn't any high priority issue Status: Completed The issue is closed Coding The issue is related with coding Team: Backend issues related to backend labels Dec 26, 2022
@BElifb BElifb marked this pull request as ready for review December 26, 2022 17:05
@BElifb BElifb changed the title Changed new_bids reset in profile to every 2 calls. hotfix/BE-38: new_bids reset Dec 26, 2022
@BElifb BElifb requested a review from KarahanS December 26, 2022 18:36
@serdarakol serdarakol self-requested a review December 26, 2022 18:44
serdarakol
serdarakol approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@serdarakol serdarakol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as intended

@BElifb BElifb merged commit a37e708 into master Dec 26, 2022
@BElifb BElifb deleted the hotfix/BE-38 branch December 26, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serdarakol serdarakol serdarakol approved these changes

@sinemKocoglu sinemKocoglu Awaiting requested review from sinemKocoglu

@KarahanS KarahanS Awaiting requested review from KarahanS

Assignees

@BElifb BElifb

Labels
Coding The issue is related with coding Effort: Low This issue can be easily handled Priority: Medium This issue should be handled, if there isn't any high priority issue Status: Completed The issue is closed Team: Backend issues related to backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BElifb @serdarakol