Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/BE-1 #180

Merged
merged 1 commit into from
Oct 19, 2022
Merged

feature/BE-1 #180

merged 1 commit into from
Oct 19, 2022

Conversation

KarahanS
Copy link
Contributor

Related to #179.

@KarahanS KarahanS added the Coding The issue is related with coding label Oct 18, 2022
@KarahanS KarahanS requested a review from BElifb October 18, 2022 16:03
@KarahanS KarahanS self-assigned this Oct 18, 2022
@KarahanS KarahanS added Effort: Low This issue can be easily handled Priority: Medium This issue should be handled, if there isn't any high priority issue labels Oct 18, 2022
@BElifb
Copy link
Contributor

BElifb commented Oct 19, 2022

It looks like the branch is 1 commit ahead, 1 commit behind the master. (I think you took out a few lines about project_logo? a week ago). Can you pull from the master and send the merge request again @KarahanS

@KarahanS KarahanS merged commit de27950 into master Oct 19, 2022
@KarahanS
Copy link
Contributor Author

KarahanS commented Oct 19, 2022 •
edited
Loading

Yeah I saw the difference but there was no merge conflict, therefore I merged the branch without any problem. Now deleting the branch feature/BE-1.
Btw, maybe we can set the settings (with the help of TA) so that remote branches are deleted immediately after being merged to master. There was such a functionality in Gitlab, most probably it's present in Github too.

@KarahanS KarahanS deleted the feature/BE-1 branch October 19, 2022 18:57
@KarahanS KarahanS changed the title Make the initials for backend feature/BE-1 Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BElifb BElifb Awaiting requested review from BElifb

Assignees

@KarahanS KarahanS

Labels
Coding The issue is related with coding Effort: Low This issue can be easily handled Priority: Medium This issue should be handled, if there isn't any high priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarahanS @BElifb