Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-String user values in work-unit data #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdanbrown
Copy link
Contributor

A small generalization to allow clients to stuff their own metadata into work-unit znodes: Json.parse[Map[String, String]](workUnitData) -> Json.parse[Map[String, Any]](workUnitData).

@jdanbrown
Copy link
Contributor Author

I agree that this change gives users more opportunity to use zk as a database instead of a coordination system, and I think that they shouldn't do that. ;)

@eribeiro
Copy link
Contributor

So even more a reason to not even open up this possibility! If you leave your backdoor open in the hopes nobody will break in, then, believe me, they will eventually break in.:-)

Again:

UPDATE: Have you evaluated the effect of those ClassCastException failures on Ordasity through tests? It would be cool to commit a unit test to do so. The comparison of 'junk' with node id bears false while throwing a runtime exception may potentially have unpredictable results, doesn't it? See, I am assuming I can be totally wrong. :)

UPDATE 2: Just out of curiosity, what kind of confusing behaviors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants