rpm2img: remove core kit specifics, set kit vendor as Publisher #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeazelm
approved these changes
Nov 27, 2024
cbgbt
reviewed
Nov 27, 2024
ginglis13
force-pushed
the
app-inv-core-kit-begone
branch
from
2226241 to
a7604fb
Compare
yeazelm
approved these changes
Dec 3, 2024
bcressey
reviewed
Dec 3, 2024
yeazelm
reviewed
Dec 3, 2024
ginglis13
force-pushed
the
app-inv-core-kit-begone
branch
from
a7604fb to
fe6d182
Compare
|
^ force push replaces deprecated |
bcressey
approved these changes
Dec 3, 2024
Remove core kit specific logic from application inventory generation such that multiple source kits can be used. Additionally, set Publisher to a kits vendor for packages that come from kits. Replace --argfile with --slurpfile in jq usage as --argfile is deprecated. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13
force-pushed
the
app-inv-core-kit-begone
branch
from
fe6d182 to
194a108
Compare
|
^ force push addresses some style feedback |
cbgbt
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related: #397
Description of changes:
Remove core kit specific logic from application inventory generation such that multiple source kits can be used.
Additionally, set Publisher to a kit's vendor for packages that come from kits.
Testing done:
Built a
k8s-1.24variant:Application Inventory
https://gist.github.com/ginglis13/58828f4c62242a53cbf139b1f9a5a307
What users will see in SSM inventory collection:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.