publish-kit: allow overridding image repository #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This override keeps the kit metadata the same, but pushes the image to an alternate repository.
sam-berning
approved these changes
Sep 16, 2024
jmt-lab
reviewed
Sep 16, 2024
| @@ -41,11 +44,16 @@ impl PublishKit { | |||
| install_tools(&toolsdir).await?; | |||
| let makefile_path = toolsdir.join("Makefile.toml"); | |||
|
|
|||
| let publish_kit_repo = match &self.kit_repo { | |||
There was a problem hiding this comment.
Should we not be populating this from the Twoliter.override file vs an argument?
There was a problem hiding this comment.
The Twoliter.override file knows about dependencies, but not about resultant kits.
sumukhballal
approved these changes
Sep 16, 2024
jmt-lab
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This allows pushing new kits to a staging repository before copying the artifacts to a final destination.
Testing done:
PUBLISH_REPO=cbgbt-test make publishafter some modifications to theMakefileto take advantage of this changeTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.