Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twoliter: allow partial lockfile validation in some scenarios #361

Merged
merged 4 commits into from
Sep 6, 2024
Merged

twoliter: allow partial lockfile validation in some scenarios #361

merged 4 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. twoliter: only run build-kit tests during integ 

    The build-kit tests significantly balloon twoliter's test time. This
marks them with `#[ignore]`, which will have them run  on `make integ`
or `make build`, but not on `cargo test`.
    @cbgbt
    cbgbt committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c451e4a View commit details
    Browse the repository at this point in the history

  2. twoliter: allow partial lockfile validation in some scenarios 

    In some CI scenarios, it's useful to drop previously-built variant
images into a Twoliter project's build directory and use Twoliter to
publish those variant images.

In these cases, Kit dependencies are not necessary, and it can be useful
to avoid resolving them and comparing them against Twoliter.lock.

This change allows skipping Kit lockfile verification only when
executing certain `twoliter make` targets.
    @cbgbt
    cbgbt committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    87624fe View commit details
    Browse the repository at this point in the history

  3. twoliter: improve callsite clarity of ImageResolver 

    Switches to a builder-style mechanism for disabling metadata fetching.
Since Rust doesn't have named args, it can be hard to know what boolean
function flags do at a callsite without going to the function signature.
    @cbgbt
    cbgbt committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8cf1e40 View commit details
    Browse the repository at this point in the history

  4. Makefile.toml: do not fetch-sources unnecessarily 

    Many cargo-make targets were fetching sources as an artifact from when
publication tools were built as part of the bottlerocket monorepo.
Now that Twoliter builds bundles these publication tools, we have need
to fetch project sources.
    @cbgbt
    cbgbt committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4703ab6 View commit details
    Browse the repository at this point in the history