use ecr public instead of region-specific images #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
reviewed
Jul 15, 2021
samuelkarp
reviewed
Jul 16, 2021
README.md
Outdated
Comment on lines
130
to
134
| ### Image Region | ||
|
|
||
| `update-operator.yaml` pulls operator images from the `us-west-2` region. | ||
| To pull from a different region, replace the image endpoint to point at one of the following endpoints. | ||
| This is not required, but pulling the image from the same region as your cluster will improve the download speed. |
There was a problem hiding this comment.
Rather than deleting this entirely, I think it'd be better to leave in the regional repositories but change the way they're described here. ECR Public isn't yet available through PrivateLink, so some people might still want to use the regional ECR repositories.
|
Push above improve README. |
webern
reviewed
Jul 16, 2021
webern
approved these changes
Jul 16, 2021
samuelkarp
reviewed
Jul 16, 2021
README.md
Outdated
Comment on lines
132
to
133
| `update-operator.yaml` pulls operator images from ECR Public. | ||
| If you still want to pull from ECR private, replace the image endpoint to point at one of the following endpoints. |
There was a problem hiding this comment.
Suggested change
| `update-operator.yaml` pulls operator images from ECR Public. | |
| If you still want to pull from ECR private, replace the image endpoint to point at one of the following endpoints. | |
| `update-operator.yaml` pulls operator images from Amazon ECR Public. | |
| You may also choose to pull from regional Amazon ECR repositories such as the following. |
samuelkarp
approved these changes
Jul 16, 2021
srgothi92
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#44
Description of changes:
Testing done:
Apply new deployment yaml file with ECR public image to aarch64 and x86 nodes
kubelet apply -f bottlerocket-update-operator.yamllog result
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.