-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate helm chart releases #514
Conversation
34b7a7a
to
e667743
Compare
Will be cool to have this publishing step automatically triggered! 🪄 Happy to approve once it's clear whether the validation scripts are intentionally not exiting with a failure code. |
e667743
to
30845c0
Compare
Addressed feedback from @markusboehme. Thanks! |
# the release before that (e.g. v1.2.3-rc3) | ||
# * If the repository head has advanced from a release tag (e.g. v1.0-g0123abcd), | ||
# select the release the current head is based on (e.g. v1.0) | ||
if $(git describe HEAD --tags | grep -Eq "^v[0-9]+(\.[0-9]+)*(-[a-z0-9]+)?$"); then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also be done with [[ $() =~ ]]
if you wanted, but both ways work.
30845c0
to
ea41df4
Compare
ea41df4
to
b214037
Compare
^ Responds to some feedback from @jpculp , and also fixes a few bugs I discovered while reading through the action runner logs. Here's the most recent actions run: With this PR being created: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛼
Issue number:
Closes #492
Description of changes:
Our current github workflow for publishing charts would create a GitHub release for each new chart, but what we want is for the Releases page to focus on the operator, and for new charts to be available in the helm repository to reflect those.
The eks-charts repo does something like this, so this commit uses a modified version of their workflow to automatically publish charts.
Testing done:
gh-pages
: Publish helm charts for v1.3.0 cbgbt/bottlerocket-update-operator#4Limitations
We have to manage our external dependencies on Helm and Kubeconform in the Makefile. Ideally we move these dependencies to the Bottlerocket SDK.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.