Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: golang image version bump from 1.13 to 1.14.1 #31

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Apr 6, 2020

Issue number:
N/A

Description of changes:
Bumps the golang image version from 1.13 to 1.14.1 to match the
bottlerocket's SDK golang toolchain version

Testing done:
make container builds the update operator container image successfully.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jahkeup
Copy link
Member

jahkeup commented Apr 6, 2020

@etungsten not sure why this is showing a diff - we got this in earlier when we went to merge in #21. I missed that the lingering golang:$version image didn't get bumped to match the sdk's go toolchain version - can you tackle bumping that?

Bumps the golang image version from 1.13 to 1.14.1 to make the
bottlerocket's SDK golang toolchain version
@etungsten etungsten changed the title Makefile: update default sdk image version from 0.8 to 0.10.1 Dockerfile: golang image version bump from 1.13 to 1.14.1 Apr 6, 2020
@etungsten etungsten requested a review from tjkirch April 6, 2020 22:26
@etungsten
Copy link
Contributor Author

Updated the PR to bump the golang image version.

Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢 :shipit:

@etungsten etungsten merged commit 81e0ef8 into bottlerocket-os:develop Apr 7, 2020
@etungsten etungsten deleted the new-sdk branch April 7, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants