change platform-version to updater-interface-version
#30
Conversation
| @@ -94,7 +94,7 @@ spec: | |||
| requiredDuringSchedulingIgnoredDuringExecution: | |||
| nodeSelectorTerms: | |||
| - matchExpressions: | |||
| - key: bottlerocket.aws/platform-version | |||
| - key: bottlerocket.aws/updater-interface-version | |||
| operator: Exists | |||
There was a problem hiding this comment.
Quick thought (and not for this particular PR to resolve):
I think we may want to update this deployment prior to making any changes to the updater components host side. The current deployments will land on hosts that end up having a bumped version without this being scoped down to updater-interface-version==1.0.0. That way we can begin to vend a newer version without impacting existing deployments (which are scheduled if the key exists at all).
I had originally aimed to have the host set its interface version by providing a compiled in default setting. If we do this then we reduce the chance that the wrong version be set for a host and eliminate the need for cluster operators to label their nodes.
[settings.kubernetes.node-labels]
"bottlerocket.aws/updater-interface-version" = "1.0.0"
This commit renames references of `platform-version` to `platform-interface-version` to better convey the label's meaning and avoid conflicts with other keywords.
etungsten
force-pushed
the
platform-version-key-change
branch
from
5687874
to
d5260a3
Compare
|
Addresses @jahkeup 's comments - updated README with suggestion. |
|
We should make sure to include instructions for the next update to change the labels to the new name. |
There was a problem hiding this comment.
Once we release this, we'll need to call out that this is a breaking change in the release notes. I think this is a good change, but anyone who is already using the update operator is going to have to make manual changes to the annotations in their Kubernetes cluster.
Issue number:
Addresses #4
Description of changes:
This commit renames references of
platform-versiontoplatform-interface-versionto better convey the label's meaning andavoid conflicts with other keywords.
Testing done:
Built my own Bottlerocket update operator container with the changes, modified
update-operator.yamlto pull that container for the agent and controller.Labelled my nodes in my cluster with the updated key name (
bottlerocket.aws/updater-interface-version) and I see the pods being scheduled to run immediately after.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.