Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.2.0 Add additional information to kubectl get bottlerocketnodes #101

Merged
merged 1 commit into from
Nov 2, 2021
Merged

0.2.0 Add additional information to kubectl get bottlerocketnodes #101

merged 1 commit into from
Nov 2, 2021

Conversation

cbgbt
Copy link
Contributor

@cbgbt cbgbt commented Nov 1, 2021 •
edited
Loading

Issue number: N/A

Description of changes: This uses the additionalPrinterColumns attribute of the BottlerocketNode custom resource definition to allow kubectl to provide more useful output when describing BottlerocketNode custom resources.

Testing done:

NAME                                               STATE              VERSION   TARGET STATE       TARGET VERSION
brn-ip-192-168-10-1.us-west-2.compute.internal     WaitingForUpdate   1.3.0     WaitingForUpdate   
brn-ip-192-168-55-52.us-west-2.compute.internal    MonitoringUpdate   1.3.0     WaitingForUpdate   
brn-ip-192-168-81-141.us-west-2.compute.internal   WaitingForUpdate   1.2.1     WaitingForUpdate   <no value>

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@cbgbt cbgbt added the 0.2.0-dev label Nov 1, 2021
@cbgbt cbgbt added this to the brupop 0.2.0 milestone Nov 1, 2021
@cbgbt cbgbt changed the base branch from develop to 0.2.0 November 1, 2021 16:12
gthao313
gthao313 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@gthao313 gthao313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚌

arnaldo2792
arnaldo2792 approved these changes Nov 2, 2021
View reviewed changes
Copy link

@arnaldo2792 arnaldo2792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cbgbt cbgbt merged commit e026e62 into bottlerocket-os:0.2.0 Nov 2, 2021
@cbgbt cbgbt deleted the 0.2.0-brn branch November 2, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaldo2792 arnaldo2792 arnaldo2792 approved these changes

@gthao313 gthao313 gthao313 approved these changes

@ecpullen ecpullen Awaiting requested review from ecpullen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
brupop 0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cbgbt @arnaldo2792 @gthao313