update Rust and Go #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt the creation of our custom targets to upstream changes. Add the host triple to the targets list, since this no longer happens implicitly. Remove the strip invocation. The LLVM library is statically linked into librustc_driver, so the dynamic library is not installed. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
tjkirch
approved these changes
Jan 4, 2021
webern
approved these changes
Jan 5, 2021
srgothi92
approved these changes
Jan 5, 2021
Correct, and there's a new scheme where some of the architecture-specific targets copy settings from a base set of options -- The "unknown" vendor is the overall default for the options struct, so we have to apply it somewhere, and it was easiest to do that immediately after loading the base settings. |
The example config is well-documented and provides context on what these settings mean, along with the others that we leave at default values. Signed-off-by: Ben Cressey <bcressey@amazon.com>
tjkirch
approved these changes
Jan 5, 2021
KCSesh
pushed a commit
to KCSesh/bottlerocket-sdk
that referenced
this pull request
Sep 10, 2024
Move Settings Models to the Settings SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #38, fixes #40
Description of changes:
Update Rust to 1.49.0. This required a few changes beyond the version bump: changing how custom targets are created; adding the host triplet to the targets list, which is no longer done implicitly; and dropping an unnecessary
stripcommand.Update Go to 1.15.6.
Testing done:
Built the four SDK combinations - aarch64 and x86_64 host, aarch64 and x86_64 target.
Built aws-k8s-1.18 variants with the four SDKs. Verified that they came up, joined the cluster, had no errors in the journal.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.