Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop dependency on glibc for nvidia kmods #194

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:
#193

Description of changes:
The NVIDIA kernel modules don't depend on the userspace C library. All of the userspace libraries are already compiled and don't need it either.

Testing done:
Builds!

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Signed-off-by: Ben Cressey <bcressey@amazon.com>
Copy link
Member

@larvacea larvacea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only Builds! but also Boots!, Joins Cluster!, and Runs nvidia_smi!

It occurred to me to do this just in case the link step might fail during boot.

@bcressey bcressey merged commit 472ccd6 into bottlerocket-os:develop Oct 14, 2024
2 checks passed
@bcressey bcressey deleted the no-glibc-for-kmods branch October 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants