Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lock): delete redis subservice lock if the refresh or release failed #617

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(lock): delete redis subservice lock if the refresh or release failed #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/engine/src/distributed/redis/subservice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ export class RedisSubservice implements DistributedSubservice {
void this.refresh(ressource)
}, DEFAULT_LOCK_TTL / 6)
} catch (e) {
delete this.locks[ressource]
this.logger.error(e, `Failed to extend lock ${ressource}`)
}
}
Expand All @@ -176,7 +177,10 @@ export class RedisSubservice implements DistributedSubservice {
clearTimeout(lock.timeout)
}

await this.redlock.release(lock.lock)
await this.redlock.release(lock.lock).catch((e: Error) => {
this.logger.error(e, `Failed to release lock ${lock.ressource}`)
})

delete this.locks[lock.ressource]
}

Expand Down