fix(instance): auto start error 404 instead of 500

packages/channels/src/base/api.ts

@@ -1,4 +1,5 @@
 import { Request, Router, Response, RequestHandler, NextFunction } from 'express'
+import { AutoStartNotFoundError } from '..'
 import { Logger } from './logger'
 import { ChannelService } from './service'
 
@@ -41,7 +42,17 @@ export class ChannelApiManager {
       this.asyncMiddleware(async (req, res, next) => {
         const nreq = req as ChannelApiRequest
         nreq.scope = req.params.scope
-        await this.service.require(nreq.scope)
+
+        try {
+          await this.service.require(nreq.scope)
+        } catch (e) {
+          if (e instanceof AutoStartNotFoundError) {
+            return res.sendStatus(404)
+          } else {
+            throw e
+          }
+        }
+
         await fn(nreq, res, next)
       })
     )

packages/channels/src/base/channel.ts

@@ -38,6 +38,13 @@ export interface ChannelStateManager {
   del(scope: string): void
 }
 
+export class AutoStartNotFoundError extends Error {
+  constructor(msg: string) {
+    super(msg)
+    Object.setPrototypeOf(this, AutoStartNotFoundError.prototype)
+  }
+}
+
 export abstract class ChannelTemplate<
   TConfig extends ChannelConfig,
   TService extends ChannelService<TConfig, any>,

packages/server/src/instances/lifetime/service.ts

@@ -1,5 +1,5 @@
 import { uuid } from '@botpress/messaging-base'
-import { Channel } from '@botpress/messaging-channels'
+import { AutoStartNotFoundError, Channel } from '@botpress/messaging-channels'
 import { DispatchService, Logger, Service, DistributedService } from '@botpress/messaging-engine'
 import { ChannelService } from '../../channels/service'
 import { ConduitService } from '../../conduits/service'
@@ -129,8 +129,17 @@ export class InstanceLifetimeService extends Service {
   }
 
   private async handleAutoStart(channel: Channel, providerName: string) {
-    const provider = await this.providers.getByName(providerName)
-    const conduit = await this.conduits.getByProviderAndChannel(provider.id, channel.meta.id)
+    const provider = await this.providers.fetchByName(providerName)
+    if (!provider) {
+      throw new AutoStartNotFoundError(`Failed to auto start because provider ${providerName} does not exist`)
+    }
+
+    const conduit = await this.conduits.fetchByProviderAndChannel(provider.id, channel.meta.id)
+    if (!conduit) {
+      throw new AutoStartNotFoundError(
+        `Failed to auto start because conduit ${provider.id}:${channel.meta.id} does not exist`
+      )
+    }
 
     const status = await this.status.fetch(conduit.id)
     if ((status?.numberOfErrors || 0) >= MAX_ALLOWED_FAILURES) {