Fix regression in assume role caching #962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in #961 and adds tests for the change.
Right now you get an error:
This was from a recent addition to botocore that added the HTTP headers into the response metadata returned from client calls.
I agree with the original change from @bashtoni to fix this in the parser. We've had an implicit contract that you can JSON dump response metadata so while we could fix this in the assume role cacher, it's possible customer code could be relying on this property, in which case we would not be able to fix.
cc @kyleknap @JordonPhillips