Only set auth_path once, fixes signing errors #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aws/aws-cli#986 The bug was that the fix_s3_host always sets the auth_path to the current path of the request.url. However, in the case of a retried request, we call fix_s3_host again which changes the auth_path to the (already modified) request path. This generates an auth error. The fix now is to check if auth_path is set, and if it is, then we can immediately return.
| from botocore.hooks import first_non_none_response | ||
| from botocore.auth import BaseSigner |
There was a problem hiding this comment.
BaseSigner is not used in this file.
|
Looks good. Had that one comment about an unused import. 🚢 |
|
Ok. I'll go ahead and remove the unused import and merge the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws/aws-cli#986
The bug was that the fix_s3_host always sets the auth_path
to the current path of the request.url. However, in the case
of a retried request, we call fix_s3_host again which changes
the auth_path to the (already modified) request path. This
generates an auth error.
The fix now is to check if auth_path is set, and if it is, then
we can immediately return.
cc @kyleknap @danielgtaylor