-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credential Scope #3048
Closed
Closed
Credential Scope #3048
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a2cb45f
credential scope
9e5c01f
nits
6f50a5b
move warning to legacy resolver
97146aa
quick fixes
bf3e3b3
refactor warning test
5021062
cache frozen creds in function scope to ensure get_frozen_credentials…
3e75ac1
add test for frozen creds cache
6961570
consolidate test rulesets into single file
7cf01d9
clean up test variables
a69acdd
pr feedback. use elements from BaseSessionTest and create_session to …
8bc5633
refactor again moving all logic to CredentialBuiltinResolver
7e1e768
remove sso support
5fc1b87
resolve frozen creds regardless if builtins are pre-set. modify BaseS…
cdf3adc
change credential scope checker method
0e4998e
more refactoring. use a mapping and abstract repeated logic
34d69e6
move ep mode validator
b6a522f
remove custom builtin handling to only check whether to resolve each …
50be381
credentials.py cleanup
78a0505
pr feedback
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe this is a pythonic thing that I don't really understand; it seems odd to allow a method that we pass in to be able to set arbitrary attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't call it Pythonic, maybe Botonic™️? We have precedence for iterating over a list of resolvers that arbitrarily resolve credentials. However, in that case the first one that is successful terminates the loop whereas this one will always complete the loop.
Only endpoint builtins that are defined in the
EndpointResolverBuiltins
enum can be used as an input parameter to the the endpoint resolver. So if somebody decided to inject a custom resolver that set some arbitrary key value pair {'foo': 'bar'} in thebuiltins
dict at runtime, an error will be raised.