Add support for urllib3 2.0 in Python 3.10+ #3034
Conversation
nateprewitt
force-pushed
the
urllib3-2.0-3.10
branch
from
d8227b8 to
c2f325e
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3034 +/- ##
===========================================
+ Coverage 93.39% 93.43% +0.04%
===========================================
Files 66 66
Lines 13963 13963
===========================================
+ Hits 13041 13047 +6
+ Misses 922 916 -6 ☔ View full report in Codecov by Sentry. |
nateprewitt
force-pushed
the
urllib3-2.0-3.10
branch
from
c2f325e to
785d224
Compare
| extras_require = { | ||
| 'crt': ['awscrt==0.16.26'], | ||
| } | ||
|
|
There was a problem hiding this comment.
Adding the environment markers to setup.cfg doesn't work with extras for older versions of setuptools. I've replicated the extras info here (similar to how we have the requires info in setup.cfg) to make sure we retain compatibility in those older setuptools versions.
|
Thanks for this. Can I ask when we can expect this to be released? We are currently blocked by urllib3 conflict with Google API. |
|
@dhhoang I believe google-auth relaxed its urllib3 pin so there's no conflict right now. Unless you're talking about something else? |
| @@ -5,7 +5,8 @@ universal = 0 | |||
| requires_dist = | |||
There was a problem hiding this comment.
It's probably worth adding a changelog entry to this.
And associated stubs. We exclude boto from dependabot due to frequency of updates. This upgrade includes the ability to use urllib3. Refs: boto/botocore#3034 We will still need to handle the elasticsearch dependency on its own. Refs: pypi#14671 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Starting in Python 3.10, the introduction of PEP 644 requires that new versions of Python require OpenSSL 1.1.1+. This will let us confidently move the pin for Python 3.10+ to support the growing adoption of urllib3 2.0.
Details on the current blockers for allowing this for all version can be found in the main tracking thread. Long term, we'll continue looking at options to expand support safely for users as we find other opportunities. For now, we'd encourage anyone looking to use urllib3 2.0 with Botocore to migrate to Python 3.10 or later.