Support loading gzip compressed models #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2628 +/- ##
===========================================
- Coverage 95.30% 95.29% -0.01%
===========================================
Files 60 60
Lines 12222 12239 +17
===========================================
+ Hits 11648 11663 +15
- Misses 574 576 +2
Continue to review full report at Codecov.
|
nateprewitt
approved these changes
Mar 4, 2022
stealthycoin
approved these changes
Apr 26, 2022
tgbugs
added a commit
to tgbugs/tgbugs-overlay
that referenced
this pull request
Mar 20, 2023
in the context of boto/botocore#2365 .json.gz loading has been merged boto/botocore#2628 so we can take advantage of it by gzing all the json in the data folder all the relevant tests pass so it seems that we are good to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for loading gzip compressed models (i.e.
.json.gzfiles) which unblocks generating more optimized wheel builds of botocore. See #2365 for more discussion. Asgzipmay not be available on all platforms support for this should gracefully fallback to the old behavior of only checking for.jsonfiles.Ideally, we'll be able to generate and distribute more optimized wheels where all models are compressed and will use these loaders instead.