-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transfer.py: fix docs #2784
Merged
Merged
transfer.py: fix docs #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the docs state that the `use_threads` keyword for `TransferConfig` when set to `False`, means that the operation will run in the main thread. This is incorrect as the operation will run in the _current thread_, which is not necessarily the main thread.
jdicke
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
nateprewitt
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tschoonj!
nateprewitt
reviewed
Mar 18, 2024
aws-sdk-python-automation
added a commit
that referenced
this pull request
Mar 19, 2024
* release-1.34.66: Bumping version to 1.34.66 Add changelog entries from botocore transfer.py: fix docs (#2784)
hswong3i
pushed a commit
to alvistack/boto-boto3
that referenced
this pull request
Mar 20, 2024
* transfer.py: fix docs Currently the docs state that the `use_threads` keyword for `TransferConfig` when set to `False`, means that the operation will run in the main thread. This is incorrect as the operation will run in the _current thread_, which is not necessarily the main thread. --------- Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docs state that the
use_threads
keyword forTransferConfig
when set toFalse
, means that the operation will run in the main thread. This is incorrect as the operation will run in the current thread, which is not necessarily the main thread.