Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer.py: fix docs #2784

Merged
merged 3 commits into from
Mar 18, 2024
Merged

transfer.py: fix docs #2784

merged 3 commits into from
Mar 18, 2024

Conversation

tschoonj
Copy link
Contributor

@tschoonj tschoonj commented Mar 8, 2021

Currently the docs state that the use_threads keyword for TransferConfig when set to False, means that the operation will run in the main thread. This is incorrect as the operation will run in the current thread, which is not necessarily the main thread.

@tschoonj tschoonj changed the base branch from master to develop March 8, 2021 11:11
Currently the docs state that the `use_threads` keyword for `TransferConfig` when set to `False`, means that the operation will run in the main thread. This is incorrect as the operation will run in the _current thread_, which is not necessarily the main thread.
@kdaily kdaily added needs-review pr/needs-review This PR needs a review from a member of the team. documentation This is a problem with documentation. labels Aug 13, 2021
Copy link

@jdicke jdicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tschoonj!

@nateprewitt nateprewitt removed pr/needs-review This PR needs a review from a member of the team. needs-review labels Mar 18, 2024
@nateprewitt nateprewitt merged commit d70b1ca into boto:develop Mar 18, 2024
33 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Mar 19, 2024
* release-1.34.66:
  Bumping version to 1.34.66
  Add changelog entries from botocore
  transfer.py: fix docs (#2784)
hswong3i pushed a commit to alvistack/boto-boto3 that referenced this pull request Mar 20, 2024
* transfer.py: fix docs

Currently the docs state that the `use_threads` keyword for `TransferConfig` when set to `False`, means that the operation will run in the main thread. This is incorrect as the operation will run in the _current thread_, which is not necessarily the main thread.
---------

Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants