Skip to content
This repository has been archived by the owner on Apr 28, 2021. It is now read-only.

refactor: parse nlu yaml before sending to nlu conversion route #37

Merged
merged 2 commits into from
Dec 23, 2020
Merged

refactor: parse nlu yaml before sending to nlu conversion route #37

merged 2 commits into from
Dec 23, 2020

Conversation

pheel
Copy link
Contributor

@pheel pheel commented Dec 22, 2020

solves ruamel perf problem

GuillaumeTech
GuillaumeTech reviewed Dec 22, 2020
View reviewed changes
Copy link
Contributor

@GuillaumeTech GuillaumeTech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every thing looks good ! just one detail, I thought parts differing from rasa were surrounded by comments, on this is addressed consider it approved !

@pheel pheel merged commit f6c4319 into master Dec 23, 2020
@pheel pheel deleted the slow-nlu-conv branch April 27, 2021 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GuillaumeTech GuillaumeTech GuillaumeTech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pheel @GuillaumeTech