fix: outdated models could not be retrained

botfront · Jan 6, 2021 · 8af1c75 · 8af1c75
1 parent d06073b
commit 8af1c75
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rasa/model.py b/rasa/model.py
@@ -536,6 +536,8 @@ def should_retrain(
         #     target_path = os.path.join(train_path, "nlu")
         #     fingerprint_comparison.nlu = not move_model(old_nlu, target_path)
         languages_to_train = fingerprint_comparison.should_retrain_nlu()
+        if languages_to_train == True:  # replace True with list of all langs
+            languages_to_train = list(new_fingerprint.get("nlu-config", {}).keys())
         for lang in old_nlu.keys():
             target_path = os.path.join(train_path, "nlu-{}".format(lang))
             if lang in new_fingerprint.get("nlu-config").keys():

diff --git a/rasa/train.py b/rasa/train.py
@@ -200,8 +200,6 @@ async def _train_async_internal(
         fingerprint_comparison = FingerprintComparisonResult(force_training=True)
 
     # bf mod >
-    if fingerprint_comparison.nlu == True:  # replace True with list of all langs
-        fingerprint_comparison.nlu = list(new_fingerprint.get("nlu-config", {}).keys())
     domain = await file_importer.get_domain()
     core_untrainable = domain.is_empty() or stories.is_empty()
     nlu_untrainable = [l for l, d in nlu_data.items() if d.is_empty()]