Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIB-9675: Fix dynamic vars and mistyped var #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CONTRIB-9675: Fix dynamic vars and mistyped var #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bookingform.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ class scheduler_booking_form extends moodleform {
protected $uploadoptions;
/** @var mixed */
protected $existing;
/** @var bool */
protected $noteoptions = [];

/**
* scheduler_booking_form constructor.
Expand Down
4 changes: 2 additions & 2 deletions renderable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ public static function make_from_appointment(slot $slot, appointment $appointmen
$info->appointment = $appointment;
$info->scheduler = $slot->get_scheduler();
$info->showslotinfo = true;
$info->showboookinginfo = true;
$info->showbookinginfo = true;
$info->showstudentdata = $info->scheduler->uses_studentdata();
$info->showresult = true;
$info->onstudentside = $onstudentside;
Expand All @@ -711,7 +711,7 @@ public static function make_for_teacher(slot $slot, appointment $appointment) {
$info->appointment = $appointment;
$info->scheduler = $slot->get_scheduler();
$info->showslotinfo = true;
$info->showboookinginfo = false;
$info->showbookinginfo = false;
$info->showstudentdata = $info->scheduler->uses_studentdata();
$info->showresult = false;
$info->onstudentside = false;
Expand Down
1 change: 0 additions & 1 deletion teacherview.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ function scheduler_print_schedulebox(scheduler $scheduler, $studentid, $groupid
$PAGE->requires->js_call_amd('mod_scheduler/delselected', 'init', [$delselectedurl->out(false)]);
$delselected = $commandbar->action_menu_link($delselectedurl, 'deleteselection', 't/delete',
'confirmdelete-selected', 'delselected');
$delselected->formid = 'delselected';
$delbuttons[] = $delselected;

if ($permissions->can_edit_all_slots() && $subpage == 'allappointments') {
Expand Down