-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sales channels page in seller center and modal in products page in seller center #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
albertfolch-redeemeum
force-pushed
the
sell-everywhere
branch
from
June 2, 2023 10:28
4576a0b
to
8a32972
Compare
albertfolch-redeemeum
changed the title
feat: sell everywhere
feat: add sales channels page in seller center and modal in products page in seller center
Jun 9, 2023
levalleux-ludo
requested changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await coreSDK.signMetaTxUpdateSellerAndOptIn(newSeller); |
- Only meta-transaction mode is implemented, so that it's not possible to run the usecase on the PR deployment preview (as the meta-tx are not activated there). I would rather go for supporting both cases, as it's done for the other type of transactions (see
if (coreSDK.isMetaTxConfigSet) { - Maybe worth having a pending popup while the transaction is submitted and not completed yet
- It's failing with my seller (ID: 26). Protocol fails with "ERC721: owner query for nonexistent token" error --> see screenshot. I think the problem comes from the AuthTokenId value that is considered to be hexadecimal (then converted to decimal) but it's already a decimal value
salesChannels
is updated in the subgraph butdeployments
array remains empty, so nothing is stored at product level, to know whether a product is added to a salesChannel or not
levalleux-ludo
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.