Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sales channels page in seller center and modal in products page in seller center #670

Merged
merged 45 commits into from
Jun 19, 2023

Conversation

albertfolch-redeemeum
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 30, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6879837
Status: ✅  Deploy successful!
Preview URL: https://3930eb48.interface-a9d.pages.dev
Branch Preview URL: https://sell-everywhere.interface-a9d.pages.dev

View logs

@albertfolch-redeemeum albertfolch-redeemeum changed the title feat: sell everywhere feat: add sales channels page in seller center and modal in products page in seller center Jun 9, 2023
@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as ready for review June 9, 2023 12:04
@albertfolch-redeemeum albertfolch-redeemeum requested a review from a team June 9, 2023 12:04
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await coreSDK.signMetaTxUpdateSellerAndOptIn(newSeller);

  • Only meta-transaction mode is implemented, so that it's not possible to run the usecase on the PR deployment preview (as the meta-tx are not activated there). I would rather go for supporting both cases, as it's done for the other type of transactions (see
    if (coreSDK.isMetaTxConfigSet) {
    )
  • Maybe worth having a pending popup while the transaction is submitted and not completed yet
  • It's failing with my seller (ID: 26). Protocol fails with "ERC721: owner query for nonexistent token" error --> see screenshot. I think the problem comes from the AuthTokenId value that is considered to be hexadecimal (then converted to decimal) but it's already a decimal value
    image
  • salesChannels is updated in the subgraph but deployments array remains empty, so nothing is stored at product level, to know whether a product is added to a salesChannel or not

Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertfolch-redeemeum albertfolch-redeemeum merged commit 8f60660 into main Jun 19, 2023
@albertfolch-redeemeum albertfolch-redeemeum deleted the sell-everywhere branch June 19, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants