Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mute button to videos #1047

Merged
merged 4 commits into from
Mar 25, 2024
Merged

feat: add mute button to videos #1047

merged 4 commits into from
Mar 25, 2024

Conversation

albertfolch-redeemeum
Copy link
Contributor

@albertfolch-redeemeum albertfolch-redeemeum commented Mar 22, 2024 •
edited
Loading

@albertfolch-redeemeum albertfolch-redeemeum requested a review from a team as a code owner March 22, 2024 19:08
@albertfolch-redeemeum albertfolch-redeemeum linked an issue Mar 22, 2024 that may be closed by this pull request
mute button to mute videos in PDP #988
Closed
@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as draft March 22, 2024 19:08
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 22, 2024 •
edited
Loading

Deploying interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 20134a2
Status: ✅  Deploy successful!
Preview URL: https://c555f5f5.interface-a9d.pages.dev
Branch Preview URL: https://988-mute-button-to-mute-vide.interface-a9d.pages.dev

View logs

levalleux-ludo
levalleux-ludo reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PB when I open this page: https://988-mute-button-to-mute-vide.interface-a9d.pages.dev/#/dapp/products/138/2a2b476-c5da-06-f516-82ba25e0822
the sound logo is "muted" but the video starts with the sound. If I click the logo first, the logo switches to unmuted and I still hear the sound. When I click the logo a second time, the logo switches to muted and the sound stop.
It looks like there is a problem with the default state of the sound

@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as ready for review March 25, 2024 13:58
@albertfolch-redeemeum albertfolch-redeemeum merged commit fbfd7ca into main Mar 25, 2024
9 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the 988-mute-button-to-mute-videos-in-pdp branch March 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levalleux-ludo levalleux-ludo levalleux-ludo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mute button to mute videos in PDP
2 participants
@albertfolch-redeemeum @levalleux-ludo