Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension to YAML #74

Closed
davidpham87 opened this issue Dec 12, 2020 · 10 comments
Closed

Extension to YAML #74

davidpham87 opened this issue Dec 12, 2020 · 10 comments

Comments

@davidpham87
Copy link

Hello,

I think babashka supports yaml now, do you think it would make sense to extend the format to YAML? It might be useful for everyone working with k8s or ansible.

Best regards,
David

@borkdude
Copy link
Owner

@davidpham87 Why not just use babashka then?

@davidpham87
Copy link
Author

This is what I did, I have my own script doing it. I thought it would be cool for jet to have this simple extension. I am crurently trying to write a pull request, not sure I managed.

@borkdude
Copy link
Owner

borkdude commented Dec 12, 2020

@davidpham87 Let's leave this issue open for feedback over the longer term. Also see #54.

@borkdude
Copy link
Owner

I've had more people ask for this and maybe it's about time we added support for YAML. If anyone is up for that, PR welcome.

@qdzo
Copy link
Contributor

qdzo commented Oct 27, 2022

Jet is great tool. Thanks!
I always use it from emacs to convert my buffers.
And I also has struggle in that it does not have yaml. I know that - this is possible via babashka - but one tool for conversion is much better.
It would be cool if this feature will have future.

@borkdude
Copy link
Owner

@qdzo Would you convert YAML to EDN?

Is anyone in this thread open to working on a PR?

@qdzo
Copy link
Contributor

qdzo commented Oct 27, 2022

50% yaml -> edn
and
50% yaml -> json.

I can spend some time to try implement this.

@borkdude
Copy link
Owner

Sounds good!

qdzo added a commit to qdzo/jet that referenced this issue Oct 28, 2022
qdzo added a commit to qdzo/jet that referenced this issue Oct 28, 2022
borkdude pushed a commit that referenced this issue Oct 28, 2022
@borkdude
Copy link
Owner

Released! Thanks @qdzo !

@qdzo
Copy link
Contributor

qdzo commented Oct 28, 2022

Thank you for the fast release !!!
Already use the new version 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants