Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no error on database backups without source dirs #56

Conversation

diivi
Copy link
Collaborator

@diivi diivi commented Mar 22, 2023

Your detailed explanation in #655 helped.

This solution passes all current tests, so it should be backward compatible, and does not raise an error anymore when source dirs don't exist:
image

Copy link
Collaborator

@witten witten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start! A few notes on the details are below.

borgmatic/execute.py Outdated Show resolved Hide resolved
borgmatic/borg/create.py Outdated Show resolved Hide resolved
borgmatic/execute.py Show resolved Hide resolved
Copy link
Collaborator

@witten witten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good to me! A few minor detail fixes, and then I think we're good to merge.

borgmatic/execute.py Outdated Show resolved Hide resolved
borgmatic/execute.py Outdated Show resolved Hide resolved
borgmatic/execute.py Outdated Show resolved Hide resolved
tests/unit/test_execute.py Outdated Show resolved Hide resolved
@witten
Copy link
Collaborator

witten commented Mar 22, 2023

Thanks for taking the time to fix this bug!

@witten witten merged commit ab64b7e into borgmatic-collective:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants