Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Concept should be capitalized #1182

Closed
varunagrawal opened this issue Apr 30, 2022 · 0 comments · Fixed by #1238
Closed

Identity Concept should be capitalized #1182

varunagrawal opened this issue Apr 30, 2022 · 0 comments · Fixed by #1238
Assignees
Labels
refactor Refactoring of code to remove rot

Comments

@varunagrawal
Copy link
Collaborator

Feature & Motivation

The Identity concept for Lie groups should be capitalized from identity to Identity since it is a static method.

Pitch

Update all identity static methods in various Lie group classes to be Identity.

NOTE this is API breaking.

@varunagrawal varunagrawal added the refactor Refactoring of code to remove rot label Apr 30, 2022
@varunagrawal varunagrawal self-assigned this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of code to remove rot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant