Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "this->" in evaluateError() in BearingRangeFactor.h #1162

Closed
daanwildiers opened this issue Apr 8, 2022 · 1 comment · Fixed by #1230
Closed

Missing "this->" in evaluateError() in BearingRangeFactor.h #1162

daanwildiers opened this issue Apr 8, 2022 · 1 comment · Fixed by #1230
Labels
easy-fix Quick and easy to fix
Milestone

Comments

@daanwildiers
Copy link

When using the
Vector evaluateError(const A1& a1, const A2& a2, boost::optional<Matrix&> H1 = boost::none, boost::optional<Matrix&> H2 = boost::none) const
function in BearingRangeFactor.h, it is not possible to compile using catkin build in a catkin workspace.
On line 82 in const Vector error = unwhitenedError({{keys[0], genericValue(a1)}, {keys[1], genericValue(a2)}}, Hs);
there is a missing this-> before unwhitenedError(. When prepending this-> the code compiles perfectly.
So it should be nice if this-> is added before unwhitenedError( on Github.

@dellaert
Copy link
Member

dellaert commented Apr 8, 2022

I assume you have a fork, can you PR this change to develop?

@varunagrawal varunagrawal added this to the GTSAM 4.2 milestone Apr 19, 2022
@varunagrawal varunagrawal added the easy-fix Quick and easy to fix label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-fix Quick and easy to fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants