Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open window on left-click. Fixes #938 #945

Merged
merged 3 commits into from
Apr 17, 2021

Conversation

m3nu
Copy link
Contributor

@m3nu m3nu commented Apr 9, 2021

XDG-compliant tray behavior: right click to open a context menu, and left click to restore the application.

If XDG_CURRENT_DESKTOP isn't set, always open the tray menu (macOS)

@m3nu m3nu requested a review from Hofer-Julian April 9, 2021 15:10
@Hofer-Julian
Copy link
Collaborator

Hofer-Julian commented Apr 10, 2021

If I remember correctly, this change was introduced to accommodate KDEs human interface guidelines.
GNOME does not have something for tray icons, since tray icons are discouraged there.

If you ask for my opinion, I would find it surprising if the window would open after a left click.
It also doesn't work well with a touchpad, since the settings would then be accessible with a right click instead.

If we change the current behaviour at all, I'd rather drop the special case for KDE and go back to the default.

@m3nu
Copy link
Contributor Author

m3nu commented Apr 13, 2021

Agreed. Not merging this. The main issue I saw is that on Gnome, it won't open the menu when left-clicking. Looks like a Qt issue. Didn't find a good workaround.

@m3nu m3nu closed this Apr 13, 2021
@sandrotosi
Copy link

@Hofer-Julian why is that surprising to open the main app window when left licking on an icon? i got that exact behavior with the system monitor applet (included with Gnome); i'm using gnome flashback, and application in the tray icon are still supported there.

@m3nu m3nu reopened this Apr 17, 2021
@Hofer-Julian
Copy link
Collaborator

The last commit seems like a good compromise

@m3nu
Copy link
Contributor Author

m3nu commented Apr 17, 2021

Then let's go with that. Thanks everyone for reviewing and weighing in!

@m3nu m3nu merged commit 15a97e4 into borgbase:master Apr 17, 2021
@m3nu m3nu deleted the issue/938/gnome-kde-toggle-window branch April 17, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants