Test fixes, avoid segfault at end #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3nu
force-pushed
the
minor/test-failures-3
branch
from
0f9bba4 to
b261adb
Compare
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
==========================================
- Coverage 73.36% 71.03% -2.34%
==========================================
Files 55 55
Lines 3720 3728 +8
==========================================
- Hits 2729 2648 -81
- Misses 991 1080 +89
Continue to review full report at Codecov.
|
m3nu
force-pushed
the
minor/test-failures-3
branch
7 times, most recently
from
4693177 to
66785f7
Compare
m3nu
force-pushed
the
minor/test-failures-3
branch
2 times, most recently
from
2d98f19 to
588e463
Compare
m3nu
force-pushed
the
minor/test-failures-3
branch
from
588e463 to
d1e86ad
Compare
samuel-w
reviewed
Feb 22, 2021
| @@ -44,7 +59,8 @@ jobs: | |||
| - name: Test with pytest (macOS) | |||
| if: runner.os == 'macOS' | |||
| run: | | |||
| pytest --cov=vorta | |||
| pytest | |||
There was a problem hiding this comment.
Is there a need to remove code coverage from macOS?
There was a problem hiding this comment.
Yes, pytest+coverage would hang indefinitely after successfully completing tests. Looks like you can't reliably have coverage + subprocesses (which we have). Using the pytest-cov plugin didn't help either.
Examples of "hung" tests:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456
Fixes #748