Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for deprecated macOS XML wifi list. #868

Merged
merged 11 commits into from
Feb 18, 2021

Conversation

m3nu
Copy link
Contributor

@m3nu m3nu commented Feb 18, 2021

Take known Wifis from other profiles, rather than system.

Fixes #766

@m3nu m3nu changed the title Remove support for deprecated macOS XML wifi list. Fixes #766 Remove support for deprecated macOS XML wifi list. Feb 18, 2021
@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #868 (3c11ec0) into master (bd0a1b8) will increase coverage by 0.12%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   73.22%   73.35%   +0.12%     
==========================================
  Files          55       55              
  Lines        3735     3715      -20     
==========================================
- Hits         2735     2725      -10     
+ Misses       1000      990      -10     
Impacted Files Coverage Δ
src/vorta/network_status/network_manager.py 73.77% <66.66%> (ø)
src/vorta/network_status/darwin.py 66.66% <83.33%> (+6.32%) ⬆️
src/vorta/network_status/abc.py 88.23% <100.00%> (ø)
src/vorta/utils.py 63.77% <100.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0a1b8...3c11ec0. Read the comment docs.

@m3nu m3nu merged commit 9a4bbf0 into borgbase:master Feb 18, 2021
@m3nu m3nu deleted the issue/766/macos-wifis branch February 18, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get known Wifis on macOS 11
2 participants