Give option to break repository lock #863
Conversation
This reverts commit c5a2e45. Turns out the tests break all the other tests. I don't know why
| f"The repository at {repo_url} might be in use by another computer. Override it and continue?")) | ||
| msg.accepted.connect(lambda: self.break_lock(profile)) |
There was a problem hiding this comment.
uuh, this almost sounds like recommending to break it.
There was a problem hiding this comment.
I thought the same actually. Here another take inspired by https://borgbackup.readthedocs.io/en/stable/usage/lock.html
The repository at {repo_url} might be in use elsewhere. Only proceed if you are certain no other Borg process on any machine is accessing the repository. Continue to break lock?
There was a problem hiding this comment.
Yeah, that is much better.
Could be also:
The repository at {repo_url} might be in use elsewhere. Only break the lock if you are certain no other Borg process on any machine is accessing the repository. Abort or break the lock?
There was a problem hiding this comment.
That will work too. I played a bit with the buttons, icon and text to make it more scary.
Continue work on #718
Fixes #713, fixes #374