Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file selector dialog #764

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Fix file selector dialog #764

merged 1 commit into from
Jan 17, 2021

Conversation

samuel-w
Copy link
Contributor

Used setOption. Fixes #693.

I have no idea why this fixes it but it fixes it. The two dialogs look different but it doesn't matter at this point.
File
Folder

@Hofer-Julian
Copy link
Collaborator

Great that you found that.
i wonder if that was a PyQt bug

@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #764 (18e7031) into master (fe93b36) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
+ Coverage   73.50%   73.52%   +0.02%     
==========================================
  Files          53       53              
  Lines        3510     3509       -1     
==========================================
  Hits         2580     2580              
+ Misses        930      929       -1     
Impacted Files Coverage Δ
src/vorta/utils.py 61.20% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe93b36...18e7031. Read the comment docs.

@Hofer-Julian Hofer-Julian merged commit 9af1eb5 into borgbase:master Jan 17, 2021
@samuel-w samuel-w deleted the kde branch January 17, 2021 20:59
@Hofer-Julian
Copy link
Collaborator

@m3nu how about a release, since this seems to affect quite a few people?

@samuel-w
Copy link
Contributor Author

It only affects arch, so I'll ask the maintainer to create a patch.

@samuel-w
Copy link
Contributor Author

samuel-w commented Jan 17, 2021

Actually, this affects KDE flatpak as well, and there are a bunch of other bug fixes since last release, so a new release would be best.

@m3nu
Copy link
Contributor

m3nu commented Jan 18, 2021

@m3nu how about a release, since this seems to affect quite a few people?

Yeah, I was thinking the same. Will see if the other outstanding macOS 11 issues in upstream projects are fixed as well.

@m3nu
Copy link
Contributor

m3nu commented Jan 18, 2021

I've added a new milestone for a 0.7.2 release. Let's add all the required PRs there and then get it done by end of Jan.

Also promoted @samuel-w to have write privs. This means you can merge other people's PRs. Please be mindful on what you merge as, undoing a bad commit isn't easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select directory on Linux (with workaround)
4 participants