Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change paste to allow copying files/folders from file manager, set DB defaults #759

Merged
merged 6 commits into from
Jan 19, 2021
Merged

Change paste to allow copying files/folders from file manager, set DB defaults #759

merged 6 commits into from
Jan 19, 2021

Conversation

samuel-w
Copy link
Contributor

@samuel-w samuel-w commented Jan 15, 2021

Possibly fixes #758. Also changed default behaviour of add_source_to_table, fixed paste button.

Edit: The test is because paste caused a crash due to the new source tab behaviour.

@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #759 (e32c861) into master (a876aed) will decrease coverage by 2.31%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   73.45%   71.14%   -2.32%     
==========================================
  Files          53       53              
  Lines        3583     3587       +4     
==========================================
- Hits         2632     2552      -80     
- Misses        951     1035      +84     
Impacted Files Coverage Δ
src/vorta/views/source_tab.py 78.34% <87.50%> (+6.44%) ⬆️
src/vorta/models.py 80.50% <100.00%> (-0.50%) ⬇️
src/vorta/keyring/darwin.py 0.00% <0.00%> (-92.11%) ⬇️
src/vorta/autostart.py 63.63% <0.00%> (-33.34%) ⬇️
src/vorta/network_status/darwin.py 33.89% <0.00%> (-27.12%) ⬇️
src/vorta/notifications.py 71.21% <0.00%> (-13.64%) ⬇️
src/vorta/keyring/abc.py 80.00% <0.00%> (-8.58%) ⬇️
src/vorta/utils.py 62.50% <0.00%> (-6.00%) ⬇️
src/vorta/network_status/abc.py 82.35% <0.00%> (-5.89%) ⬇️
src/vorta/config.py 94.44% <0.00%> (-5.56%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a876aed...e32c861. Read the comment docs.

@samuel-w samuel-w changed the title Change paste to allow copying files/folders from file manager Change paste to allow copying files/folders from file manager, set DB defaults Jan 17, 2021
@m3nu m3nu requested a review from Hofer-Julian January 18, 2021 09:00
@m3nu
Copy link
Contributor

m3nu commented Jan 18, 2021

Looks good, but can't test it.

Copy link
Collaborator

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on GNOME with nautilus

@samuel-w samuel-w merged commit 031a5f6 into borgbase:master Jan 19, 2021
@samuel-w samuel-w deleted the paste_folders branch January 19, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select multiple folders
4 participants