Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort tree dialogs alphabetically #741

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Sort tree dialogs alphabetically #741

merged 6 commits into from
Dec 16, 2020

Conversation

samuel-w
Copy link
Contributor

@samuel-w samuel-w commented Dec 8, 2020

Fixes #646, fixes #664.

Sorts both diff and restore due to inheritance. Puts folders first then files, but doesn't allow changing of sorting order.

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #741 (0e98a26) into master (6d0ef76) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   73.49%   73.51%   +0.01%     
==========================================
  Files          53       53              
  Lines        3505     3507       +2     
==========================================
+ Hits         2576     2578       +2     
  Misses        929      929              
Impacted Files Coverage Δ
src/vorta/views/partials/tree_view.py 71.03% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0ef76...0e98a26. Read the comment docs.

@samuel-w
Copy link
Contributor Author

samuel-w commented Dec 8, 2020

It moves file of size zero to the top, since folders and files have the same size. Few files will have size zero, but its very annoying.
Screenshot_20201208_153431

@m3nu m3nu self-assigned this Dec 15, 2020
@m3nu m3nu merged commit abd41b9 into borgbase:master Dec 16, 2020
@samuel-w samuel-w deleted the extract_order branch December 16, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sorting to the restore window archive: extract: file order, folder order, hidden file order
3 participants