Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort archive sizes in archive tab #729

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Sort archive sizes in archive tab #729

merged 1 commit into from
Nov 29, 2020

Conversation

samuel-w
Copy link
Contributor

No description provided.

@samuel-w samuel-w changed the title Sort archive sizes in table Sort archive sizes in archive tab Nov 27, 2020
@m3nu
Copy link
Contributor

m3nu commented Nov 28, 2020

So this allows sorting by size or always sorts by size?

@samuel-w
Copy link
Contributor Author

It sorts by size correctly. Before it alphabetically sorted the size strings leading to the wrong result.

@samuel-w
Copy link
Contributor Author

Also it pushes the empty rows to the bottom when sorting descendingly, and pushes them to the top when sorting ascendingly

@m3nu
Copy link
Contributor

m3nu commented Nov 29, 2020

I think the sorting should be by date by default since this is how Borg sorts. By size isn't meaningful.

Sorting by alphabet was an approximation of date-based sorting. Maybe not fully correct, so I'm open to improve on that. By size doesn't make sense, since I will generally look for an archive done on a specific day. I really don't care about the size. I just want my data back on a specific day.

Of course sorting using other columns could be possible too and there may be a case where size is useful.

@samuel-w
Copy link
Contributor Author

This doesn't change the sorting behaviour of anything else. It just makes the sizes sort correctly.
Before:
Before
After:
After

@m3nu
Copy link
Contributor

m3nu commented Nov 29, 2020

Great. That was my question before. If you fixed sorting by size, that's perfect.

@m3nu m3nu merged commit fc2b70d into borgbase:master Nov 29, 2020
@samuel-w samuel-w deleted the sort_size branch November 29, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants