Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last exec_ instances, add archive deletion test, retain archive deletion message #722

Merged
merged 9 commits into from
Nov 20, 2020
Merged

Remove last exec_ instances, add archive deletion test, retain archive deletion message #722

merged 9 commits into from
Nov 20, 2020

Conversation

samuel-w
Copy link
Contributor

That should be the last of the dialog exec_.

I'm doing this to prepare for PyQt6 https://riverbankcomputing.com/software/pyqt/download.

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #722 (931a1e9) into master (39b7f58) will increase coverage by 1.24%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   73.50%   74.74%   +1.24%     
==========================================
  Files          52       52              
  Lines        3378     3374       -4     
==========================================
+ Hits         2483     2522      +39     
+ Misses        895      852      -43     
Impacted Files Coverage Δ
src/vorta/__main__.py 0.00% <0.00%> (ø)
src/vorta/application.py 68.93% <0.00%> (ø)
src/vorta/views/repo_tab.py 81.17% <71.42%> (+8.23%) ⬆️
src/vorta/views/archive_tab.py 84.71% <100.00%> (+3.35%) ⬆️
src/vorta/views/extract_dialog.py 96.49% <100.00%> (+9.72%) ⬆️
src/vorta/views/main_window.py 84.24% <100.00%> (+0.10%) ⬆️
src/vorta/views/repo_add_dialog.py 69.02% <100.00%> (+0.27%) ⬆️
src/vorta/utils.py 61.74% <0.00%> (-2.74%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b7f58...931a1e9. Read the comment docs.

@samuel-w samuel-w changed the title Remove last exec_ instances, add archive deletion test Remove last exec_ instances, add archive deletion test, retain archive deletion message Nov 19, 2020
@m3nu m3nu merged commit 0b69612 into borgbase:master Nov 20, 2020
@m3nu
Copy link
Contributor

m3nu commented Nov 20, 2020

Thanks! Looks like a good cleanup.

@samuel-w samuel-w deleted the refactor_add_rename branch November 20, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants