Refactor add and rename to not use exec_ #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exec_ not recommended per documentation https://doc.qt.io/qt-5/qdialog.html#exec. Now the tests run on the actual client
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
==========================================
+ Coverage 72.94% 73.56% +0.61%
==========================================
Files 52 52
Lines 3375 3378 +3
==========================================
+ Hits 2462 2485 +23
+ Misses 913 893 -20
Continue to review full report at Codecov.
|
m3nu
approved these changes
Nov 19, 2020
|
Nice to see some refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec_ not recommended per documentation https://doc.qt.io/qt-5/qdialog.html#exec.
Now the tests run on the actual client
rootdir is copied from #548