-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup database at exit, use write-ahead logging #696
Conversation
We should look into async/await. Maybe some startup tasks can be offloaded. |
Async is apparently slower for databases https://stackoverflow.com/questions/39803746/peewee-and-peewee-async-why-is-async-slower |
Is it worth making startup slower for this low-priority task? How about doing it in the background with the scheduler or when closing? |
I moved it so it runs right before exiting. |
Added write-ahead logging https://www.sqlite.org/wal.html. It speeds up tests a lot, 30 sec to 16 sec. |
Strange. The tests aren't faster in the CI, but they are faster on my local machine. Still useful though. |
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 70.85% 73.50% +2.64%
==========================================
Files 53 53
Lines 3507 3510 +3
==========================================
+ Hits 2485 2580 +95
+ Misses 1022 930 -92
Continue to review full report at Codecov.
|
https://www.tutorialspoint.com/sqlite/sqlite_vacuum.htm