Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable exit dialog #681

Merged
merged 15 commits into from
Jan 18, 2021
Merged

Add option to disable exit dialog #681

merged 15 commits into from
Jan 18, 2021

Conversation

samuel-w
Copy link
Contributor

@samuel-w samuel-w commented Oct 6, 2020

Fixes #680.

Tested by setting is_system_tray_available to False

@codecov-io
Copy link

codecov-io commented Dec 13, 2020

Codecov Report

Merging #681 (70222e8) into master (19b4946) will decrease coverage by 2.65%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   74.48%   71.83%   -2.66%     
==========================================
  Files          53       53              
  Lines        3422     3444      +22     
==========================================
- Hits         2549     2474      -75     
- Misses        873      970      +97     
Impacted Files Coverage Δ
src/vorta/views/main_window.py 77.70% <6.66%> (-6.54%) ⬇️
src/vorta/views/misc_tab.py 81.39% <36.36%> (-15.67%) ⬇️
src/vorta/models.py 80.80% <75.00%> (-0.32%) ⬇️
src/vorta/keyring/darwin.py 0.00% <0.00%> (-100.00%) ⬇️
src/vorta/autostart.py 63.63% <0.00%> (-33.34%) ⬇️
src/vorta/network_status/darwin.py 33.89% <0.00%> (-27.12%) ⬇️
src/vorta/notifications.py 71.21% <0.00%> (-13.64%) ⬇️
src/vorta/keyring/abc.py 81.48% <0.00%> (-11.12%) ⬇️
src/vorta/network_status/abc.py 82.35% <0.00%> (-5.89%) ⬇️
src/vorta/config.py 94.44% <0.00%> (-5.56%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b4946...70222e8. Read the comment docs.

@m3nu m3nu self-assigned this Dec 15, 2020
@m3nu m3nu merged commit a47af86 into borgbase:master Jan 18, 2021
@samuel-w samuel-w deleted the no_tray branch January 18, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable the exit dialog "Should Vorta continue ro run in the background"
3 participants