-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom options to borg create command #677
Conversation
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 73.20% 73.22% +0.02%
==========================================
Files 55 55
Lines 3724 3735 +11
==========================================
+ Hits 2726 2735 +9
- Misses 998 1000 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The create command is not being saved correctly and the backup fails if it's not defined due to adding another empty parameter to the Borg command.
2021-01-18 19:40:51,916 - vorta.borg.borg_thread - INFO - Running command /usr/local/bin/borg create --list --progress --info --log-json --json --filter=AM -C zstd,8 --exclude-from /var/folders/g0/6wysw4qn6kl38gkv58jgkkfc0000gp/T/tmpamcx_yuh --exclude-if-present .nobackup xxx.repo.borgbase.com:repo::nyx2-2021-01-18T19:40:51 /Users/manu/...
2021-01-18 19:40:52,395 - vorta.borg.borg_thread - WARNING - usage: borg create [-h] [--critical] [--error] [--warning] [--info] [--debug]
2021-01-18 19:40:52,396 - vorta.borg.borg_thread - WARNING - [--debug-topic TOPIC] [-p] [--log-json]
2021-01-18 19:40:52,397 - vorta.borg.borg_thread - WARNING - [--lock-wait SECONDS] [--bypass-lock] [--show-version]
2021-01-18 19:40:52,397 - vorta.borg.borg_thread - WARNING - [--show-rc] [--umask M] [--remote-path PATH]
2021-01-18 19:40:52,398 - vorta.borg.borg_thread - WARNING - [--remote-ratelimit RATE] [--consider-part-files]
2021-01-18 19:40:52,399 - vorta.borg.borg_thread - WARNING - [--debug-profile FILE] [--rsh RSH] [-n] [-s] [--list]
2021-01-18 19:40:52,399 - vorta.borg.borg_thread - WARNING - [--filter STATUSCHARS] [--json] [--no-cache-sync]
2021-01-18 19:40:52,399 - vorta.borg.borg_thread - WARNING - [--no-files-cache] [--stdin-name NAME] [--stdin-user USER]
2021-01-18 19:40:52,401 - vorta.borg.borg_thread - WARNING - [--stdin-group GROUP] [--stdin-mode M] [-e PATTERN]
2021-01-18 19:40:52,401 - vorta.borg.borg_thread - WARNING - [--exclude-from EXCLUDEFILE] [--pattern PATTERN]
2021-01-18 19:40:52,401 - vorta.borg.borg_thread - WARNING - [--patterns-from PATTERNFILE] [--exclude-caches]
2021-01-18 19:40:52,402 - vorta.borg.borg_thread - WARNING - [--exclude-if-present NAME] [--keep-exclude-tags]
2021-01-18 19:40:52,403 - vorta.borg.borg_thread - WARNING - [--exclude-nodump] [-x] [--numeric-owner] [--noatime]
2021-01-18 19:40:52,404 - vorta.borg.borg_thread - WARNING - [--noctime] [--nobirthtime] [--nobsdflags] [--ignore-inode]
2021-01-18 19:40:52,404 - vorta.borg.borg_thread - WARNING - [--files-cache MODE] [--read-special] [--comment COMMENT]
2021-01-18 19:40:52,405 - vorta.borg.borg_thread - WARNING - [--timestamp TIMESTAMP] [-c SECONDS]
2021-01-18 19:40:52,406 - vorta.borg.borg_thread - WARNING - [--chunker-params PARAMS] [-C COMPRESSION]
2021-01-18 19:40:52,407 - vorta.borg.borg_thread - WARNING - ARCHIVE [PATH ...]
2021-01-18 19:40:52,407 - vorta.borg.borg_thread - WARNING - borg create: error: argument ARCHIVE: Invalid location format: ""
Placement is great now. but there is an error, when adding more than 2 arguments. That's because Python won't split them. |
Thanks for the contribution @samuel-w! Active community members like yourself ensure the quality and relevance of this project. |
Fixes #274
Fixes #561 indirectly, add
--remote-path borg1
to actually fixExample output with
--dry-run
in box: