Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom options to borg create command #677

Merged
merged 25 commits into from
Feb 18, 2021
Merged

Add custom options to borg create command #677

merged 25 commits into from
Feb 18, 2021

Conversation

samuel-w
Copy link
Contributor

@samuel-w samuel-w commented Oct 3, 2020

Fixes #274

Fixes #561 indirectly, add --remote-path borg1 to actually fix

Example output with --dry-run in box:

2020-10-03 00:09:29,308 - vorta.borg.borg_thread - INFO - Running command /home/user/Projects/vorta/venv/bin/borg create --list --progress --info --log-json --json --filter=AM -C zstd,8 --dry-run --exclude-if-present .nobackup /mnt/data/borg-backblaze::PC-PC-backblaze-2020-10-03T00:09:29 /home/user

@samuel-w samuel-w changed the title Add custom create options Add custom create option= Oct 3, 2020
@samuel-w samuel-w changed the title Add custom create option= Add custom create option Oct 3, 2020
@samuel-w samuel-w changed the title Add custom create option Add custom options to borg create command Oct 3, 2020
@m3nu m3nu self-assigned this Oct 30, 2020
@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #677 (f39e992) into master (355ddda) will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   73.20%   73.22%   +0.02%     
==========================================
  Files          55       55              
  Lines        3724     3735      +11     
==========================================
+ Hits         2726     2735       +9     
- Misses        998     1000       +2     
Impacted Files Coverage Δ
src/vorta/borg/create.py 48.95% <50.00%> (+0.02%) ⬆️
src/vorta/models.py 80.69% <80.00%> (-0.22%) ⬇️
src/vorta/views/schedule_tab.py 87.85% <88.46%> (+0.47%) ⬆️
src/vorta/views/main_window.py 78.39% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355ddda...f39e992. Read the comment docs.

src/vorta/assets/UI/scheduletab.ui Outdated Show resolved Hide resolved
src/vorta/assets/UI/scheduletab.ui Outdated Show resolved Hide resolved
@samuel-w samuel-w requested a review from m3nu December 16, 2020 23:31
Copy link
Contributor

@m3nu m3nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create command is not being saved correctly and the backup fails if it's not defined due to adding another empty parameter to the Borg command.

2021-01-18 19:40:51,916 - vorta.borg.borg_thread - INFO - Running command /usr/local/bin/borg create --list --progress --info --log-json --json --filter=AM -C zstd,8  --exclude-from /var/folders/g0/6wysw4qn6kl38gkv58jgkkfc0000gp/T/tmpamcx_yuh --exclude-if-present .nobackup xxx.repo.borgbase.com:repo::nyx2-2021-01-18T19:40:51 /Users/manu/...
2021-01-18 19:40:52,395 - vorta.borg.borg_thread - WARNING - usage: borg create [-h] [--critical] [--error] [--warning] [--info] [--debug]
2021-01-18 19:40:52,396 - vorta.borg.borg_thread - WARNING - [--debug-topic TOPIC] [-p] [--log-json]
2021-01-18 19:40:52,397 - vorta.borg.borg_thread - WARNING - [--lock-wait SECONDS] [--bypass-lock] [--show-version]
2021-01-18 19:40:52,397 - vorta.borg.borg_thread - WARNING - [--show-rc] [--umask M] [--remote-path PATH]
2021-01-18 19:40:52,398 - vorta.borg.borg_thread - WARNING - [--remote-ratelimit RATE] [--consider-part-files]
2021-01-18 19:40:52,399 - vorta.borg.borg_thread - WARNING - [--debug-profile FILE] [--rsh RSH] [-n] [-s] [--list]
2021-01-18 19:40:52,399 - vorta.borg.borg_thread - WARNING - [--filter STATUSCHARS] [--json] [--no-cache-sync]
2021-01-18 19:40:52,399 - vorta.borg.borg_thread - WARNING - [--no-files-cache] [--stdin-name NAME] [--stdin-user USER]
2021-01-18 19:40:52,401 - vorta.borg.borg_thread - WARNING - [--stdin-group GROUP] [--stdin-mode M] [-e PATTERN]
2021-01-18 19:40:52,401 - vorta.borg.borg_thread - WARNING - [--exclude-from EXCLUDEFILE] [--pattern PATTERN]
2021-01-18 19:40:52,401 - vorta.borg.borg_thread - WARNING - [--patterns-from PATTERNFILE] [--exclude-caches]
2021-01-18 19:40:52,402 - vorta.borg.borg_thread - WARNING - [--exclude-if-present NAME] [--keep-exclude-tags]
2021-01-18 19:40:52,403 - vorta.borg.borg_thread - WARNING - [--exclude-nodump] [-x] [--numeric-owner] [--noatime]
2021-01-18 19:40:52,404 - vorta.borg.borg_thread - WARNING - [--noctime] [--nobirthtime] [--nobsdflags] [--ignore-inode]
2021-01-18 19:40:52,404 - vorta.borg.borg_thread - WARNING - [--files-cache MODE] [--read-special] [--comment COMMENT]
2021-01-18 19:40:52,405 - vorta.borg.borg_thread - WARNING - [--timestamp TIMESTAMP] [-c SECONDS]
2021-01-18 19:40:52,406 - vorta.borg.borg_thread - WARNING - [--chunker-params PARAMS] [-C COMPRESSION]
2021-01-18 19:40:52,407 - vorta.borg.borg_thread - WARNING - ARCHIVE [PATH ...]
2021-01-18 19:40:52,407 - vorta.borg.borg_thread - WARNING - borg create: error: argument ARCHIVE: Invalid location format: ""

@m3nu
Copy link
Contributor

m3nu commented Feb 10, 2021

Placement is great now. but there is an error, when adding more than 2 arguments. That's because Python won't split them.

@m3nu m3nu self-assigned this Feb 10, 2021
@m3nu m3nu merged commit bd0a1b8 into borgbase:master Feb 18, 2021
@m3nu
Copy link
Contributor

m3nu commented Feb 18, 2021

Thanks for the contribution @samuel-w! Active community members like yourself ensure the quality and relevance of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSError: [Errno 107] Transport endpoint is not connected Add custom options to borg create command
3 participants