Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse existing window when bringing to front. #674

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Reuse existing window when bringing to front. #674

merged 3 commits into from
Oct 3, 2020

Conversation

m3nu
Copy link
Contributor

@m3nu m3nu commented Sep 30, 2020

Fixes #340

@m3nu m3nu requested a review from samuel-w September 30, 2020 05:12
samuel-w
samuel-w approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@samuel-w samuel-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test this due to no macOS, LGTM.

@m3nu
Copy link
Contributor Author

m3nu commented Oct 3, 2020

Shouldn't be macOS-specific. Error happens whenever the main window is doing something and we try to recreate it.

Anyways. Will merge it.

@m3nu m3nu merged commit 364d401 into borgbase:master Oct 3, 2020
@m3nu m3nu deleted the issue/340/reopen-crash branch January 20, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-w samuel-w samuel-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when re-opening main window during repo setup
2 participants
@m3nu @samuel-w